From 42177873f82a0530f4c3cc7ecbcc6e2f145630b6 Mon Sep 17 00:00:00 2001 From: Ed Schouten Date: Sat, 10 Jan 2015 09:41:32 +0100 Subject: [PATCH] Remove weak reference construct from fenv code. I grepped through the FreeBSD source tree and for me, it seems to be totally unclear why these two specific functions are weak references. Such a construct is commonly used by FreeBSD's threading library (libthr) to override certain functions, but I can't find any traces of that. Just use the function name directly. This fixes a compiler warning as well (-Wmissing-prototypes). --- amd64/fenv.c | 7 ++----- i387/fenv.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/amd64/fenv.c b/amd64/fenv.c index 63b0680..0ed84c2 100644 --- a/amd64/fenv.c +++ b/amd64/fenv.c @@ -128,7 +128,7 @@ feupdateenv(const fenv_t *envp) } int -__feenableexcept(int mask) +feenableexcept(int mask) { uint32_t mxcsr, omask; uint16_t control; @@ -145,7 +145,7 @@ __feenableexcept(int mask) } int -__fedisableexcept(int mask) +fedisableexcept(int mask) { uint32_t mxcsr, omask; uint16_t control; @@ -160,6 +160,3 @@ __fedisableexcept(int mask) __ldmxcsr(mxcsr); return (omask); } - -__weak_reference(__feenableexcept, feenableexcept); -__weak_reference(__fedisableexcept, fedisableexcept); diff --git a/i387/fenv.c b/i387/fenv.c index 5ad4de6..b6b26f7 100644 --- a/i387/fenv.c +++ b/i387/fenv.c @@ -182,7 +182,7 @@ feupdateenv(const fenv_t *envp) } int -__feenableexcept(int mask) +feenableexcept(int mask) { uint32_t mxcsr, omask; uint16_t control; @@ -204,7 +204,7 @@ __feenableexcept(int mask) } int -__fedisableexcept(int mask) +fedisableexcept(int mask) { uint32_t mxcsr, omask; uint16_t control; @@ -224,6 +224,3 @@ __fedisableexcept(int mask) } return (omask); } - -__weak_reference(__feenableexcept, feenableexcept); -__weak_reference(__fedisableexcept, fedisableexcept);