Display filename when fxconv raise an error #5

New Issue

Open

opened 2020-06-04 22:03:43 +02:00 by Darks · 4 comments

Darks commented

2020-06-04 22:03:43 +02:00

Contributor

When compiling with -j*, fxconv is called many times in parallel. Thus, error messages may not be synchronized.

Example below:

fxconv --bopti-image assets-cg/img/sprites/sprite1_back.png -o build-cg/assets/img/sprites/sprite7_back.png.o --cg --toolchain=sh-elf name:img_sprite7_back  profile:p4
...
fxconv --bopti-image assets-cg/img/sprites/sprite8_big.png -o build-cg/assets/img/sprites/sprite8_big.png.o --cg --toolchain=sh-elf name:img_sprite8_big  profile:p4
fxconv --bopti-image assets-cg/img/sprites/sprite8_front.png -o build-cg/assets/img/sprites/sprite8_front.png.o --cg --toolchain=sh-elf name:img_sprite8_front  profile:p4
/usr/lib/python3.8/site-packages/PIL/Image.py:1044: UserWarning: Couldn't allocate palette entry for transparency
  warnings.warn("Couldn't allocate palette entry for transparency")
/usr/lib/python3.8/site-packages/PIL/Image.py:1044: UserWarning: Couldn't allocate palette entry for transparency
  warnings.warn("Couldn't allocate palette entry for transparency")

It may be great to display the filename in the log entry when fxconv raise a warning or an error.

When compiling with `-j*`, `fxconv` is called many times in parallel. Thus, error messages may not be synchronized. Example below: ``` fxconv --bopti-image assets-cg/img/sprites/sprite1_back.png -o build-cg/assets/img/sprites/sprite7_back.png.o --cg --toolchain=sh-elf name:img_sprite7_back profile:p4 ... fxconv --bopti-image assets-cg/img/sprites/sprite8_big.png -o build-cg/assets/img/sprites/sprite8_big.png.o --cg --toolchain=sh-elf name:img_sprite8_big profile:p4 fxconv --bopti-image assets-cg/img/sprites/sprite8_front.png -o build-cg/assets/img/sprites/sprite8_front.png.o --cg --toolchain=sh-elf name:img_sprite8_front profile:p4 /usr/lib/python3.8/site-packages/PIL/Image.py:1044: UserWarning: Couldn't allocate palette entry for transparency warnings.warn("Couldn't allocate palette entry for transparency") /usr/lib/python3.8/site-packages/PIL/Image.py:1044: UserWarning: Couldn't allocate palette entry for transparency warnings.warn("Couldn't allocate palette entry for transparency") ``` It may be great to display the filename in the log entry when fxconv raise a warning or an error.

Lephenixnoir commented

2020-06-11 22:16:13 +02:00

Owner

That's possible, though the warning you're getting right now is from PIL, not fxconv, so I can't catch it or change it.

It's funny to see how fxconv-like this error message is, but if you look closely it's nowhere in the source code. ^^

I'll check fxconv errors to make sure to add the file path here at least.

That's possible, though the warning you're getting right now is from PIL, not fxconv, so I can't catch it or change it. It's funny to see how fxconv-like this error message is, but if you look closely it's nowhere in the source code. ^^ I'll check fxconv errors to make sure to add the file path here at least.