`drect_border` unexpected behavior #14

New Issue

Closed

opened 2021-04-30 01:38:48 +02:00 by kdx · 2 comments

kdx commented

2021-04-30 01:38:48 +02:00

Hello, I wanted to use the drect_border function today and wasn't expecting it to "clip" borders to the screen boundaries. I wanted to use it for a moving box that goes out of bound, the current behavior prevent this kind of usage.

Here is a minimal code demonstrating what I mean:

#include <gint/display.h>
#include <gint/keyboard.h>

int
main(void)
{
        dclear(C_WHITE);
        drect_border(-666, -7, 42, 1337, C_WHITE, 8, C_BLACK);
        dupdate();

        getkey();
        return 1;
}

Behavior expected:

....*.........
....*.........
....*.........
....*.........
....*.........

What gint draws:

*****.........
*...*.........
*...*.........
*...*.........
*****.........

Thank you for your attention.

Hello, I wanted to use the `drect_border` function today and wasn't expecting it to "clip" borders to the screen boundaries. I wanted to use it for a moving box that goes out of bound, the current behavior prevent this kind of usage. Here is a minimal code demonstrating what I mean: ```c #include <gint/display.h> #include <gint/keyboard.h> int main(void) { dclear(C_WHITE); drect_border(-666, -7, 42, 1337, C_WHITE, 8, C_BLACK); dupdate(); getkey(); return 1; } ``` Behavior expected: ```text ....*......... ....*......... ....*......... ....*......... ....*......... ``` What gint draws: ```text *****......... *...*......... *...*......... *...*......... *****......... ``` Thank you for your attention.

Lephenixnoir referenced this issue from a commit

2021-04-30 09:42:56 +02:00

display: fix bound checking in drect_border (#14)

Lephenixnoir commented

2021-04-30 09:43:47 +02:00

Owner

You are correct, this is a bug. The expected behavior is that clipping does not move the border. Since drect() does all the needed checks anyway, I dropped the bound-checking code to keep only the simple cases.

You can check this out on dev, if everything works correctly for you this will be in the next release (which shouldn't take too long since the USB driver is coming).

You are correct, this is a bug. The expected behavior is that clipping does not move the border. Since `drect()` does all the needed checks anyway, I dropped the bound-checking code to keep only the simple cases. You can check this out on `dev`, if everything works correctly for you this will be in the next release (which shouldn't take too long since the USB driver is coming).

kdx commented

2021-04-30 10:23:46 +02:00

Author

It all works as expected on dev, thank you!

It all works as expected on `dev`, thank you!