#5 CJK_punctuation

Merged
Lephenixnoir merged 3 commits from Alice/uf5x7:CJK_punctuation into master 1 year ago
Alice commented 1 year ago

I’m going to need some fairy dust on my messy drawing, could you take care of that ? ♥

I'm going to need some fairy dust on my messy drawing, could you take care of that ? ♥
Lephenixnoir commented 1 year ago
Owner

Wow, thanks a lot! Now tackling CJK, this is becoming challenging xD

Here’s my take on it, please take it as suggestions (not sure all of them are improvements /o\).

On the README the number of code points is usually indicated even if not all the characters are covered, in that case that would be 64 😃

Also you can remove the entries about U+3010 and U+3011 below the future work section.

Wow, thanks a lot! Now tackling CJK, this is becoming challenging xD Here's my take on it, please take it as suggestions (not sure all of them are improvements /o\\). On the README the number of code points is usually indicated even if not all the characters are covered, in that case that would be 64 :smiley: Also you can remove the entries about `U+3010` and `U+3011` below the future work section.
Alice commented 1 year ago
Poster

You’re welcome ! (It’s not like I was doing this to see your pixel-art skill at work)

There are some mistake (made by me) that need to be fixed (e.g. U+3018 and U+3019 are inverted), so I will look more into it while I’m at it ^^

That’s just me being klutz and doing 12*4 instead of 16*4 >_<

OK, I will do it.

You're welcome ! (It's not like I was doing this to see your pixel-art skill at work) There are some mistake (made by me) that need to be fixed (e.g. `U+3018` and `U+3019` are inverted), so I will look more into it while I'm at it ^^ That's just me being klutz and doing `12*4` instead of `16*4` >_< OK, I will do it.
Alice commented 1 year ago
Poster

Well, I didn’t really found anything to improve...

So I inverted U+3018 and U+3019 and shifted U+3008 to U+3011.

Well, I didn't really found anything to improve... So I inverted `U+3018` and `U+3019` and shifted `U+3008` to `U+3011`.
Lephenixnoir commented 1 year ago
Owner

Excellent! You can commit this onto your branch directly, I’m ready to merge it. 😃

Excellent! You can commit this onto your branch directly, I'm ready to merge it. :smiley:
Alice commented 1 year ago
Poster

And done ♥

And done ♥
Lephenixnoir closed this pull request 1 year ago
Lephenixnoir commented 1 year ago
Owner

There you go, thanks again!

There you go, thanks again!
Alice deleted branch CJK_punctuation 1 year ago
The pull request has been merged as dd9564fdd5.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.