From 0ed1523470ba33a2afba1510a19e51c4af9e329a Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Tue, 3 Nov 2015 18:25:23 +0100 Subject: [PATCH] Fix potential endless loop in pending_signals::clear * sigproc.cc (pending_signals::clear): Fix previous fix resulting in yet another endless loop. Signed-off-by: Corinna Vinschen --- winsup/cygwin/ChangeLog | 5 +++++ winsup/cygwin/sigproc.cc | 13 ++++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index dfeaf39dc..b990d9f15 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,8 @@ +2015-11-03 Corinna Vinschen + + * sigproc.cc (pending_signals::clear): Fix previous fix resulting in + yet another endless loop. + 2015-11-02 Corinna Vinschen * include/netinet/ip.h (MAX_IPOPTLEN): Define. diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index fbc738d4f..6a7708f0c 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -402,16 +402,11 @@ sig_clear (int sig) void pending_signals::clear (_cygtls *tls) { - sigpacket *q = &start, *qnext; + sigpacket *q, *qnext; - while ((qnext = q->next)) - { - if (qnext->sigtls == tls) - { - q->next = qnext->next; - qnext->si.si_signo = 0; - } - } + for (q = &start; (qnext = q->next); q->next = qnext->next) + if (qnext->sigtls == tls) + qnext->si.si_signo = 0; } /* Clear pending signals of specific thread. Called from _cygtls::remove */