PlaneteCasio/libc
1
0
Fork 0
Code Issues 6 Pull requests Releases Wiki Activity

cygwin: fix potential buffer overflow in fork

Browse source 
When fork fails, we can use "%s" now with system_sprintf for the errmsg
rather than a (potentially too small) buffer for the format string.

* fork.cc (fork): Use "%s" with system_printf now.
This commit is contained in:
Michael Haubenwallner 2017-10-09 18:58:24 +02:00 committed by Corinna Vinschen
parent 4449971295
commit 1adbd77cab
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
winsup/cygwin/fork.cc
View file

@ -618,13 +618,8 @@ fork ()
if (!grouped.errmsg)
syscall_printf ("fork failed - child pid %d, errno %d", grouped.child_pid, grouped.this_errno);
else
{
char buf[strlen (grouped.errmsg) + sizeof ("child %d - , errno 4294967295 ")];
strcpy (buf, "child %d - ");
strcat (buf, grouped.errmsg);
strcat (buf, ", errno %d");
system_printf (buf, grouped.child_pid, grouped.this_errno);
}
system_printf ("child %d - %s, errno %d", grouped.child_pid,
grouped.errmsg, grouped.this_errno);
set_errno (grouped.this_errno);
}