From 29e22d07d6f0146bd59b65418cd248a19f1e477a Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Wed, 4 Feb 2009 15:26:22 +0000 Subject: [PATCH] * security.cc (alloc_sd): Disable generating default permission entries for directories. --- winsup/cygwin/ChangeLog | 5 +++++ winsup/cygwin/security.cc | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 9eb93adac..382b77817 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,8 @@ +2009-02-04 Corinna Vinschen + + * security.cc (alloc_sd): Disable generating default permission entries + for directories. + 2009-01-29 Corinna Vinschen * fhandler_disk_file.cc (fhandler_disk_file::readdir): Fix inode number diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc index 66dc93c98..c9de92b0a 100644 --- a/winsup/cygwin/security.cc +++ b/winsup/cygwin/security.cc @@ -608,6 +608,12 @@ alloc_sd (path_conv &pc, __uid32_t uid, __gid32_t gid, int attribute, acl_len += ace->Header.AceSize; } +#if 0 + /* CV 2009-02-04: Setting these inherit attributes for new dirs never was + really POSIX-like but rather a concession for native Win32 processes. + Disabled for now. Let's test if that has really a visible negative + impact. */ + /* Construct appropriate inherit attribute for new directories */ if (S_ISDIR (attribute) && !acl_exists) { @@ -647,6 +653,7 @@ alloc_sd (path_conv &pc, __uid32_t uid, __gid32_t gid, int attribute, well_known_world_sid, acl_len, inherit)) return NULL; } +#endif /* Set AclSize to computed value. */ acl->AclSize = acl_len;