From 4e8e54543e9e9dc20786e1f554d92186f812517e Mon Sep 17 00:00:00 2001 From: Christopher Faylor Date: Sun, 11 Dec 2005 22:31:00 +0000 Subject: [PATCH] * winsup.api/ltp/dup03.c (cleanup): Fix longstanding off-by-one error when setting array element to -1. --- winsup/testsuite/ChangeLog | 5 +++++ winsup/testsuite/winsup.api/ltp/dup03.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/winsup/testsuite/ChangeLog b/winsup/testsuite/ChangeLog index be6c82ce4..66944c0df 100644 --- a/winsup/testsuite/ChangeLog +++ b/winsup/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2005-12-11 Christopher Faylor + + * winsup.api/ltp/dup03.c (cleanup): Fix longstanding off-by-one error + when setting array element to -1. + 2005-06-11 Christopher Faylor * winsup.api/pthread/cancel2.c: Use explicit initializer for mutex. diff --git a/winsup/testsuite/winsup.api/ltp/dup03.c b/winsup/testsuite/winsup.api/ltp/dup03.c index bcc347aac..dc2efbb0a 100644 --- a/winsup/testsuite/winsup.api/ltp/dup03.c +++ b/winsup/testsuite/winsup.api/ltp/dup03.c @@ -271,8 +271,8 @@ cleanup() /* close the open file we've been dup'ing */ if (Fd) { - for (; Nfds >0 ; Nfds--) { - if (close(Fd[Nfds-1]) == -1) { + while (Nfds-- >0) { + if (close(Fd[Nfds]) == -1) { tst_resm(TWARN, "close(%s) Failed, errno=%d : %s", Fname, errno, strerror(errno)); }