From d2f788a3fc3f3c65ecfbd685647e3367b62e3a83 Mon Sep 17 00:00:00 2001 From: Lephe Date: Sat, 7 May 2022 18:12:44 +0100 Subject: [PATCH] render-cg: fix negative alpha values being miscompared in P8 --- src/render-cg/image/image_p8_clearbg.S | 3 +++ src/render-cg/image/image_p8_dye.S | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/render-cg/image/image_p8_clearbg.S b/src/render-cg/image/image_p8_clearbg.S index da661f0..3193d7d 100644 --- a/src/render-cg/image/image_p8_clearbg.S +++ b/src/render-cg/image/image_p8_clearbg.S @@ -79,6 +79,9 @@ nop .endif + exts.b r8, r8 + nop + START mov.b @r3+, \TMP2 diff --git a/src/render-cg/image/image_p8_dye.S b/src/render-cg/image/image_p8_dye.S index 6a8130e..659fd87 100644 --- a/src/render-cg/image/image_p8_dye.S +++ b/src/render-cg/image/image_p8_dye.S @@ -56,10 +56,13 @@ nop .endif - mov.w @(2,r8), r0 /* cmd.color_2 (dye value) */ + mov.w @r8+, r11 /* cmd.color_1 ≤ 255, thus zero-extended */ nop - mov.w @r8, r8 /* cmd.color_1 ≤ 255, thus zero-extended */ + mov.w @r8+, r0 /* cmd.color_2 (dye value) */ + nop + + exts.b r11, r8 mov #0, r11 START