Vhex-Kernel-Core
/
fxlibc
2
2
Fork 3
Code Issues 1 Pull Requests Releases Wiki Activity

Fix signedness issues with strcmp and strncmp #4

Merged
Lephenixnoir merged 2 commits from Heath123/fxlibc:heath123-patch-1 into master 2022-11-24 14:23:22 +01:00
Conversation 1 Commits 2 Files Changed 2 +2 -2
Heath123 commented 2022-11-24 13:37:35 +01:00
Contributor
Copy Link

It was returning a negative value when it should have been positive. Note that I only tested this in the one case where it was causing an issue so this may be incorrect.

It was returning a negative value when it should have been positive. Note that I only tested this in the one case where it was causing an issue so this may be incorrect.
Heath123 added 2 commits 2022-11-24 13:37:36 +01:00
Lephenixnoir commented 2022-11-24 14:23:06 +01:00
Collaborator
Copy Link

Good call! I was unaware that characters were compared as unsigned. This doesn't often come up since ASCII characters are identical either way. Thanks for contributing.

Good call! I was unaware that characters were compared as unsigned. This doesn't often come up since ASCII characters are identical either way. Thanks for contributing.
Lephenixnoir merged commit eb83e7442f into master 2022-11-24 14:23:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Vhex-Kernel-Core/fxlibc#4
No description provided.
Delete Branch "Heath123/fxlibc:heath123-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?