devs
/
emoji-picker-element
mirror of https://github.com/nolanlawson/emoji-picker-element.git
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: simplify further

This commit is contained in:
Nolan Lawson 2023-12-11 19:15:12 -08:00
parent ff3bb13ce3
commit baa696b07b
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/picker/components/Picker/framework.js
View File

@ -67,7 +67,6 @@ function patch (expressions, instanceBindings) {
currentExpression,
binding: {
expressionIndex,
withinAttribute,
attributeName,
attributeValuePre,
attributeValuePost
@ -83,7 +82,7 @@ function patch (expressions, instanceBindings) {
instanceBinding.currentExpression = expression
if (withinAttribute) {
if (attributeName) { // attribute replacement
targetNode.setAttribute(attributeName, attributeValuePre + toString(expression) + attributeValuePost)
} else { // text node / child element / children replacement
let newNode
@ -172,8 +171,6 @@ function parse (tokens) {
}
const binding = {
withinTag,
withinAttribute,
attributeName,
attributeValuePre,
attributeValuePost,
@ -226,9 +223,9 @@ function traverseAndSetupBindings (dom, elementsToBindings) {
const binding = bindings[i]
let targetNode
if (binding.withinAttribute) {
if (binding.attributeName) { // attribute binding
targetNode = element
} else { // not within an attribute, so has a placeholder comment
} else { // not an attribute binding, so has a placeholder comment
if (!bindingIdsToPlaceholderComments) { // find all placeholder comments once
bindingIdsToPlaceholderComments = findBindingIdsToPlaceholderComments(element)
}