Throw error when e vspace does not exist

Dr-Carlos commented

2022-04-16 00:26:01 +02:00

Collaborator

Hello!

In this commit I have fixed the vspace parameter (I didn't realise I needed to run parser.accept_options()), and e will now throw an error if the vspace passed in does not exist.

Hello! In this commit I have fixed the vspace parameter (I didn't realise I needed to run `parser.accept_options()`), and e will now throw an error if the vspace passed in does not exist.

Dr-Carlos added 1 commit 2022-04-16 00:26:03 +02:00

9b334d0ee0 _e: throw error when vspace does not exist

Lephenixnoir commented

2022-04-17 17:52:26 +02:00

Owner

Thanks! This works well. However you shouldn't throw an error; to be honest exceptions have screwed me over in the past and I'm getting rid of them in fxos as much as possible. For instance right now if you try to autocomplete after e vspace=whatever, fxos crashes.

The parser being used for autocompletion means that you can't throw, only print. Also since I don't have value categories for options, this actually disables autocompletion of vspace names, which is unfortunate.

However, you have also fixed symbols being autocompleted from the wrong vspace, which is really cool!

Thanks! This works well. However you shouldn't throw an error; to be honest exceptions have screwed me over in the past and I'm getting rid of them in fxos as much as possible. For instance right now if you try to autocomplete after `e vspace=whatever`, fxos crashes. The parser being used for autocompletion means that you can't throw, only print. Also since I don't have value categories for options, this actually disables autocompletion of vspace names, which is unfortunate. However, you have also fixed symbols being autocompleted from the wrong vspace, which is really cool!

Dr-Carlos force-pushed master from 7ae47d6523 to 789fc3325c

2022-04-17 23:53:41 +02:00

Compare

Dr-Carlos commented

2022-04-17 23:54:55 +02:00

Author

Collaborator

I have changed the throw to a FxOS_log at ERR level.