Merge pull request 'Improved src/save.c + misc' (#1) from KikooDX/AST3_C:master into master

Reviewed-on: https://gitea.planet-casio.com/Tituya/AST3_C/pulls/1

.gitignore

@@ -1,4 +1,4 @@
-build-cg/*
+build-cg/
 
 # ---> C
 # Prerequisites

build.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/bash
+#!/bin/sh
 echo "making setlevel.c from editor"
 rm src/setlevel.c
 python3 compile_level.py

src/save.c

@@ -5,74 +5,73 @@
 
 int retcode;
 int valeur = 0;
-int times[LEVEL_MAX]; //moche et je le sais... A essayer l'allocution dynamique
+int times[LEVEL_MAX]; /* ugly and I know it... try memory allocation */
+static const uint16_t *filepath = u"\\\\fls0\\AST3.sav";
 
-
-/*savefile() write the time of all the player's times in the savefile
-savefile() is long to execute. That's why it must be call once per new record only to avoid loading times.*/
+/* savefile() write the time of all the player's times in the savefile.
+ * savefile() is long to execute. That's why it must be call once per
+ * new record only to avoid loading times. */
 void savefile(void)
 {
-	uint16_t *filepath = u"\\\\fls0\\AST3.sav";
 	int descriptor;
 	
 	descriptor = BFile_Open(filepath, BFile_WriteOnly);
-	for(int i = 0; i != 15; i++) BFile_Write(descriptor, &times[i], sizeof(times[i]));
+	BFile_Write(descriptor, times, sizeof(times));
 	BFile_Close(descriptor);
 }
 
-/*loadfile() is only call by the function loadtime() because loadtime() set the value of "valeur".
-It store in the global retcode the time of the player. This function is call once per level
-in the level selection menu to avoid loading time.*/
+/* loadfile() is only called by the function loadtime() because
+ * loadtime() set the value of "valeur".  It store in the global retcode
+ * the time of the player. This function is called once per level in the
+ * level selection menu to avoid loading time. */
 void loadfile(void)
 {
 	int descriptor;
-	uint16_t *filepath = u"\\\\fls0\\AST3.sav";
 	descriptor = BFile_Open(filepath, BFile_ReadOnly);
-	BFile_Read(descriptor, &retcode, 4, 4*valeur);
+	BFile_Read(descriptor, &retcode,
+	           sizeof(times[0]), sizeof(times[0]) * valeur);
 	BFile_Close(descriptor);
 }
 
-/*savetimes() is call when the player has reached the end of a level. 
-If his time is better than the save time, it will call the function savefile
-else, nothing append to avoid loading time*/
+/* savetimes() is call when the player has reached the end of a level.
+ * If his time is better than the save time, it will call the function
+ * savefile() else, nothing append to avoid loading time. */
 void savetimes(float framelevel, int id_level)
 {
-	if(times[id_level-1]>(int)(framelevel/FPS*100) || times[id_level-1]==0) 
+	if(times[id_level - 1] > (int)(framelevel / FPS * 100) ||
+	   times[id_level - 1] == 0) 
 	{
-		times[id_level-1]=(int)(framelevel/FPS*100);
+		times[id_level - 1] = (int)(framelevel / FPS * 100);
 		draw_end((int)framelevel, id_level, 1);
 		gint_switch(savefile);
 	}
 }
 
-/*restore() is call when the app is load, it will create the save file if it doesn't exist.
-If the file exist, it will read all times from the save and store them in the global times[]*/
-void restore()
+/* restore() is call when the app is load, it will create the save file
+ * if it doesn't exist. If the file exist, it will read all times from
+ * the save and store them in the global times[] */
+void restore(void)
 {
-	uint16_t *filepath = u"\\\\fls0\\AST3.sav";
 	struct BFile_FileInfo fileInfo;
 	int handle;
 	uint16_t foundpath[30];
-	int size = 80;
+	int size = sizeof(times);
 	int descriptor;
 	char checkfile = BFile_FindFirst(filepath, &handle, foundpath, &fileInfo);
 	BFile_FindClose(handle);
-	if(checkfile == -1) BFile_Create(filepath, BFile_File, &size);
-	else
-	{
+	if(checkfile == -1)
+		BFile_Create(filepath, BFile_File, &size);
+	else {
 		descriptor = BFile_Open(filepath, BFile_ReadOnly);
-		for(int i = 0; i != 15; i++) 
-		{
-			BFile_Read(descriptor, &retcode, 4, 4*i);
-			times[i] = (int)retcode;
-		}
+		BFile_Read(descriptor, times, sizeof(times), 0);
 		BFile_Close(descriptor);
 	}
 }
 
-/*loadtime is changing the current value of the global "valeur" to set it to the current level
-then it execute loadfile and read and stock in the global retcode 4 bits
-at the place 4*level (times are in 4 bits)  */
+/* loadtime() is changing the current value of the global "valeur" to
+ * set it to the current level then it execute loadfile and read and
+ * stock in the global retcode 4 bytes at the place 4*level (times are in
+ * 4 bytes) */
 int loadtime(int a)
 {
 	valeur = a;