Vhex-Kernel-Core
/
fxlibc
2
2
Fork 3
Code Issues 1 Pull Requests Releases Wiki Activity

Add support for scanf() functions #5

Closed
Slyvtt wants to merge 0 commits from Slyvtt/fxlibc:dev into dev
pull from: Slyvtt/fxlibc:dev
merge into: Vhex-Kernel-Core:dev
Conversation 3 Commits - Files Changed -
Slyvtt commented 2023-02-19 21:55:16 +01:00
First-time contributor
Copy Link

Added support of scanf( )-likes functions. Test addin can be found in my Gitea here

Status of development can be seen here : status

Added support of scanf( )-likes functions. Test addin can be found [in my Gitea here](https://gitea.planet-casio.com/Slyvtt/scanftest) Status of development can be seen here : [status](https://gitea.planet-casio.com/Slyvtt/fxlibc/src/commit/2bf06360c028cbd93484dc1afc35b3e24cbb63c5/src/stdio/scanf/scan.c#L74-L112)
Slyvtt added 8 commits 2023-02-19 21:55:17 +01:00
Slyvtt added 1 commit 2023-02-19 21:56:12 +01:00
Lephenixnoir changed title from dev to Add support for scanf() functions 2023-02-24 15:59:53 +01:00
Slyvtt added 4 commits 2023-03-01 22:10:53 +01:00
Slyvtt added 1 commit 2023-03-04 13:35:59 +01:00
Slyvtt added 1 commit 2023-03-04 16:30:24 +01:00
Slyvtt commented 2023-03-04 16:38:29 +01:00
Author
First-time contributor
Copy Link

This is now ok on my side.

Only the integer type modifiers j/z/t are missing in the current implementation.

All verifications tests with asserts are in the depot here.

All is compared to return from glibc6.2

This is now ok on my side. Only the integer type modifiers **j/z/t** are missing in the current implementation. All verifications tests with asserts are in the [depot here](https://gitea.planet-casio.com/Slyvtt/scanftest). All is compared to return from glibc6.2
Slyvtt added 1 commit 2023-03-05 20:31:21 +01:00
Slyvtt added 1 commit 2023-03-06 22:16:31 +01:00
Slyvtt added 2 commits 2023-03-08 22:41:08 +01:00
Slyvtt added 1 commit 2023-03-09 18:12:02 +01:00
Lephenixnoir force-pushed dev from aee725a3d6 to 493312032b 2023-05-26 21:04:53 +02:00 Compare
Lephenixnoir force-pushed dev from 493312032b to 09b33ca2fa 2023-05-26 21:07:21 +02:00 Compare
Lephenixnoir commented 2024-01-14 13:22:05 +01:00
Collaborator
Copy Link

Finally taking this up.

I have adapted the scanftest add-in into a (so-far untested) file into the FxLibcTest add-in. I have confirmed however that the tests pass on Linux, i.e. that the asserts are correct (just in case).

I have built your branch, but according to unit tests it appears to break most of the strto*() functions in stdlib. I'll go around to fixing that before moving on to testing scanf() and cleaning up the implementation a bit.

Finally taking this up. I have adapted the scanftest add-in into a (so-far untested) file into the [FxLibcTest](https://gitea.planet-casio.com/Lephenixnoir/FxLibcTest) add-in. I have confirmed however that the tests pass on Linux, i.e. that the asserts are correct (just in case). I have built your branch, but according to unit tests it appears to break most of the `strto*()` functions in stdlib. I'll go around to fixing that before moving on to testing scanf() and cleaning up the implementation a bit.
Lephenixnoir commented 2024-01-14 23:09:10 +01:00
Collaborator
Copy Link

After pushing manually and a lot of cleaning, this is now done. Thanks for contributing :)

After pushing manually and a lot of cleaning, this is now done. Thanks for contributing :)
Lephenixnoir closed this pull request 2024-01-14 23:09:10 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Vhex-Kernel-Core/fxlibc#5
No description provided.
Delete Branch "Slyvtt/fxlibc:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?