devs/PCv5
devs
/
PCv5
7
10
Fork 4
Code Issues 25 Pull Requests Releases Wiki Activity

search #145

Merged
Eragon merged 19 commits from search into dev 2023-09-05 22:50:27 +02:00
Conversation 1 Commits 19 Files Changed 11 +386 -17
Eragon commented 2023-09-05 22:05:10 +02:00
Member
Copy Link
No description provided.
Eragon added 18 commits 2023-09-05 22:05:20 +02:00
Lephenixnoir reviewed 2023-09-05 22:13:00 +02:00
app/templates/base/base.html Outdated
@ -21,3 +20,3 @@
{% include "base/footer.html" %}
</div>
{% include "base/footer.html" %}
Lephenixnoir commented 2023-09-05 22:13:00 +02:00
Owner
Copy Link

Pourquoi il a bougé celui-là ? La page est divisée en deux, la navbar à gauche, le .container à droite. Le footer devrait être dans le container pour être centré non pas par rapport à la page complète mais par rapport à la partie de la page qui n'est pas couverte pas la navbar.

Pourquoi il a bougé celui-là ? La page est divisée en deux, la navbar à gauche, le `.container` à droite. Le footer devrait être dans le container pour être centré non pas par rapport à la page complète mais par rapport à la partie de la page qui n'est pas couverte pas la navbar.
Eragon marked this conversation as resolved
Lephenixnoir commented 2023-09-05 22:14:18 +02:00
Owner
Copy Link

LGTM à part ce détail-là. Sur le CCS je fais confiance

LGTM à part ce détail-là. Sur le CCS je fais confiance
Eragon added 1 commit 2023-09-05 22:41:58 +02:00
Eragon added 1 commit 2023-09-05 22:46:22 +02:00
Eragon force-pushed search from 3c502f3b55 to ab8270cbba 2023-09-05 22:47:15 +02:00 Compare
Eragon merged commit db065f83f3 into dev 2023-09-05 22:50:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Core

Required to release v5

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
easy

The fix is considered as easy to make

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
performance

Something is slow, not optimized

  
proposal

Feature to be discussed, RFC

  
question

More information is needed

  
security

This issue is a security breach

  
warning

It works, but for how long?

  
wontfix

This won't be fixed

No Label
Core
bug
duplicate
easy
enhancement
help wanted
invalid
performance
proposal
question
security
warning
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: devs/PCv5#145
No description provided.
Delete Branch "search"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?